Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serverless pricing info #201

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Nov 17, 2024

Fix elastic/platform-docs-team#492 by updating pricing info as approved by @linyaru in the associated Gdoc. Also make minor edits for style and clarity.

Previews


Notes:

@marciw marciw requested a review from a team as a code owner November 17, 2024 16:24
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@marciw marciw changed the title Update Elasticsearch serverless pricing info Update serverless pricing info Nov 17, 2024
leemthompo
leemthompo previously approved these changes Nov 18, 2024
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few suggestions :)

serverless/pages/pricing.asciidoc Outdated Show resolved Hide resolved
serverless/pages/pricing.asciidoc Outdated Show resolved Hide resolved
@georgewallace
Copy link
Contributor

run docs-build

@georgewallace
Copy link
Contributor

@leemthompo since @marciw was out, I worked on accepting your feedback and fixing some merge conflicts. If this looks good can you sign off when you get in. I think I got everything.

cc: @marciw

@leemthompo
Copy link
Contributor

I had to push a commit to fix CI, so I in turn have to invite @florent-leborgne to give final approval so we can merge this 😅

@leemthompo leemthompo merged commit b18be69 into elastic:main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants