Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multiple RTOS v2 #4

Merged
merged 28 commits into from
Apr 7, 2020

Conversation

pablogs9
Copy link
Member

@pablogs9 pablogs9 commented Mar 26, 2020

This PR add sample apps for Micro XRCE-DDS and some RTOS.

This PR superseded #3

@pablogs9 pablogs9 mentioned this pull request Mar 26, 2020
3 tasks
@pablogs9 pablogs9 requested review from jfm92 and julionce March 26, 2020 08:32
@julionce julionce changed the base branch from master to microxrce_dev April 2, 2020 06:07
FreeRTOS/Makefile Outdated Show resolved Hide resolved
FreeRTOS/Makefile Outdated Show resolved Hide resolved
@INCLUDES@
)

set(__BIG_ENDIAN__ 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you set the endianness?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -0,0 +1,3 @@
# Micro-XRCE-DDS Apps

This repo contains Micro XRCE-DDS sample aplications and build instructions for the supported embedded RTOS: Zephyr, FreeRTOS and Nuttx.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This repo contains Micro XRCE-DDS sample aplications and build instructions for the supported embedded RTOS: Zephyr, FreeRTOS and Nuttx.
This repo contains Micro XRCE-DDS sample applications and build instructions for the supported embedded RTOS: Zephyr, FreeRTOS and NuttX.

Zephyr/README.md Outdated Show resolved Hide resolved
Zephyr/README.md Outdated Show resolved Hide resolved
Zephyr/arm_toolchain.cmake.in Show resolved Hide resolved
set(CMAKE_C_FLAGS_INIT "@CFLAGS@" CACHE STRING "" FORCE)
set(CMAKE_CXX_FLAGS_INIT "@CXXFLAGS@" CACHE STRING "" FORCE)

set(__BIG_ENDIAN__ 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you set the endianness?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

Comment on lines 137 to 152
// int acc_timeout = 0;
// size_t read;

// uart_irq_rx_disable(platform->uart_dev);
// read = ring_buf_get(&in_ringbuf, buf, len);
// uart_irq_rx_enable(platform->uart_dev);

// if(read < len){
// k_sleep(K_MSEC(timeout));

// uart_irq_rx_disable(platform->uart_dev);
// read += ring_buf_get(&in_ringbuf, &buf[read], len-read);
// uart_irq_rx_enable(platform->uart_dev);
// }

// return read;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Co-Authored-By: Julián Bermúdez Ortega <[email protected]>
@pablogs9 pablogs9 requested a review from julionce April 2, 2020 07:49
@julionce julionce merged commit 18b7f30 into microxrce_dev Apr 7, 2020
@pablogs9 pablogs9 deleted the feature/refactor_multiple_rtos_v2 branch July 16, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants