Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multiple rtos #3

Closed
wants to merge 25 commits into from
Closed

Conversation

pablogs9
Copy link
Member

@pablogs9 pablogs9 commented Mar 17, 2020

This PR add sample apps for Micro XRCE-DDS and some RTOS.

  • FreeRTOS
  • Zephyr. WIP, adding Micro XRCE-DDS as CMake external project required.
  • Nuttx. No changes done. Does it may work? @jfm92

julianbermudez and others added 24 commits November 2, 2018 09:19
* Modified Micro XRCE-DDS toolchain source.

* Removed Micro XRCE-DDS toolchain.
Co-Authored-By: Julián Bermúdez Ortega <[email protected]>
Co-Authored-By: Julián Bermúdez Ortega <[email protected]>
Co-Authored-By: Julián Bermúdez Ortega <[email protected]>
Co-Authored-By: Julián Bermúdez Ortega <[email protected]>
Co-Authored-By: Julián Bermúdez Ortega <[email protected]>
Update gitignore


Building FreeRTOS


Removed folder


Update


Working state
Copy link
Contributor

@julionce julionce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a moment. Why do you copy all FreeRTOS here? Is there not FreeRTOS git repository?

@julionce julionce removed their assignment Mar 19, 2020
@pablogs9
Copy link
Member Author

Yes, it is possible to put FreeRTOS as a submodule (in fact it pretty new check this: https://github.com/FreeRTOS/FreeRTOS-Kernel) BUT we are providing a STM32CubeMX project. This project is who includes FreeRTOS in the folder structure, so if we remove the folder and add it as a submodule, when someone modifies the STM32CubeMX project (to add some new GPIO for example) and regenerates the code it will add FreeRTOS again...

It is not the best solution but we have to choose between providing a STM32CubeMX project where it is possible to reconfigure the HAL and BSP or to give a closed configuration where we determine the folder trees.

@pablogs9 pablogs9 assigned julionce and unassigned pablogs9 Mar 19, 2020
@julionce julionce self-requested a review March 19, 2020 11:14
Copy link
Contributor

@julionce julionce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In such a case I prefer the STM32CubeMX approach.
Please, add the STM32CubeMX project and update the README with the instructions.
It could be also useful to provide a list of steps that the users should follow to port Micro XRCE-DDS for their platform over FreeRTOS.
Do you thing it is possible?

@pablogs9 pablogs9 mentioned this pull request Mar 26, 2020
3 tasks
@pablogs9
Copy link
Member Author

Superseed by #4

@pablogs9 pablogs9 closed this Mar 26, 2020
@pablogs9 pablogs9 deleted the feature/refactor_multiple_rtos branch July 16, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants