Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with greeting [BOTKIT] #59

Merged
merged 11 commits into from
Dec 3, 2019
Merged

Fix bug with greeting [BOTKIT] #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
15863c6
Update botkit botkit-mock botbuilder-adapter-slack
nikitasakau Nov 25, 2019
67e9bca
Used new botkit-mock in specs
nikitasakau Nov 25, 2019
9fd64cd
Refactored tests in order to share the same controller
nikitasakau Nov 25, 2019
f910c47
Used for greeting queries plain strings
nikitasakau Nov 25, 2019
32db95c
Parse greeting keys via regexp in order not to trigger on words which…
nikitasakau Nov 25, 2019
fce5696
Fixed tests styles, added test for fixed bug with greeting
nikitasakau Nov 25, 2019
d0f972a
Do not use Should in specs because it is useless
nikitasakau Nov 28, 2019
d379bef
Fixed warnings in spec removing SlackApiMock because it is useless
nikitasakau Dec 3, 2019
744b0d6
Removed semicolons in spec helpers because we do not use them in othe…
nikitasakau Dec 3, 2019
eb9cfd4
Added Good afternoon as trigger for greeting because some people use it
nikitasakau Dec 3, 2019
7dd236b
Removed useless imports in mention spec
nikitasakau Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion features/greeting/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ const replies = require('./replies.js')
const randomArrayItem = array => array[Math.floor(Math.random() * array.length)]

module.exports = (controller) => {
const matchKeys = queries.join('|')
const regexp = new RegExp(`\\b(${matchKeys})\\b`, 'i')

controller.hears(
queries,
regexp,
['message', 'direct_message'],
async (bot, message) => {
await bot.reply(message, { text: randomArrayItem(replies) })
Expand Down
3 changes: 2 additions & 1 deletion features/greeting/queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
module.exports = [
'Hello',
'Good morning',
'Good afternoon',
'G\'day',
'\^Hi\$',
'Hi',
'Morning',
'Hey',
]
Loading