Code

Fix bug with greeting [BOTKIT]#59

Code

Merged

nikitasakau merged 11 commits intomove-to-botkitdatarockets/mona:move-to-botkitfrom botkit-fix-greetingdatarockets/mona:botkit-fix-greetingCopy head branch name to clipboardDec 3, 2019

+795-2,703

Commits

Commits on Nov 25, 2019

• Update botkit botkit-mock botbuilder-adapter-slack

  nikitasakau

  committed
  15863c6

  Copy full SHA for 15863c6

• Used new botkit-mock in specs

  nikitasakau

  committed
  67e9bca

  Copy full SHA for 67e9bca

• Refactored tests in order to share the same controller

  nikitasakau

  committed
  9fd64cd

  Copy full SHA for 9fd64cd

• Used for greeting queries plain strings

  nikitasakau

  committed
  f910c47

  Copy full SHA for f910c47

• Parse greeting keys via regexp in order not to trigger on words which includes greeting words

  nikitasakau

  committed
  32db95c

  Copy full SHA for 32db95c

• Fixed tests styles, added test for fixed bug with greeting

  nikitasakau

  committed
  fce5696

  Copy full SHA for fce5696

Commits on Nov 28, 2019

• Do not use Should in specs because it is useless

  nikitasakau

  committed
  d0f972a

  Copy full SHA for d0f972a

Commits on Dec 3, 2019

• Fixed warnings in spec removing SlackApiMock because it is useless

  nikitasakau

  committed
  d379bef

  Copy full SHA for d379bef

• Removed semicolons in spec helpers because we do not use them in other places

  nikitasakau

  committed
  744b0d6

  Copy full SHA for 744b0d6

• Added Good afternoon as trigger for greeting because some people use it

  nikitasakau

  committed
  eb9cfd4

  Copy full SHA for eb9cfd4

• Removed useless imports in mention spec

  nikitasakau

  committed
  7dd236b

  Copy full SHA for 7dd236b