Fix bug with greeting [BOTKIT] #59
Conversation
… includes greeting words
nikitasakau
added
BOTKIT
bug
infra
| messages: [{ | ||
| text: '```hi```', isAssertion: true, | ||
| text: 'they', isAssertion: true, | ||
| }], | ||
| }]).then(message => assert.deepEqual(message, {})) |
There was a problem hiding this comment.
thoughts about moving this method to a helper method for tests? It's duplicated lot of times
There was a problem hiding this comment.
@AleksSenkou Do you mean message => assert.deepEqual(message, {}) only or the whole usersInput?
There was a problem hiding this comment.
@nikitasakov I'm thinking about:
await userInputs('they').then(message => assert.deepEqual(message, {}))thoughts?
There was a problem hiding this comment.
Why do you use await on promise?
There was a problem hiding this comment.
or:
await userInputs('they').then(noAnswerFromBotExpected)There was a problem hiding this comment.
@lazycoder9 I did as in docs - https://github.com/gratifyguy/botkit-mock. Or it is not the same?
|
@nikitasakov I'm not sure it related to, but should warnings be removed in this MR? Or does it not affect anything? Everyone usually has a different attitude towards the warnings. |
|
I need this branch to be merged to finish write tests for order water feature, dudes. |
|
@npupko Do you mean that we can merge it for now, but create separate issue for refactoring? |
|
@nikitasakov Yes, it will be awesome. How much time do you need to complete this issue? |
|
@nikitasakov what about this comment? #59 (comment) |
|
@AleksSenkou We decided to refactor it in separate issue. Going to continue discussion there. #61 |
Fix #53 #31
botbuilder-adapter-slack,botkit,botkit-mockin order to use middlewares in specs (Only the last versionbotkit-mocksupports them)