Fix neurips configs after hydra integration #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 82 82
Lines 7819 7819
=======================================
Hits 5232 5232
Misses 2587 2587
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the neurips2023 configs after the hydra integration that broke the
config_overridetag.I didn't go for a very sophisticated structure like @luis-mueller proposes in #421. I tried mainly to replicate the original structure of the configs with a base config and specific tags that define layer types and task names.