Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all configs on the main branch are compatible with experimental changes (i.e. seed -> checkpoint name) #354

Closed
s-maddrellmander opened this issue Jun 12, 2023 · 2 comments · Fixed by #421 or #423
Closed

Make sure all configs on the main branch are compatible with experimental changes (i.e. seed -> checkpoint name) #354

s-maddrellmander opened this issue Jun 12, 2023 · 2 comments · Fixed by #421 or #423
Milestone
Graphium paper

Comments

@s-maddrellmander
Copy link
Contributor

Making a note of this here to make sure it's not lost prior to publicising the library
@DomInvivo DomInvivo added this to the Graphium paper milestone Jun 29, 2023
@DomInvivo
Copy link
Collaborator

@s-maddrellmander don't forget to close this issue when done

This was linked to pull requests Aug 23, 2023
Configs v2 #421
Merged
Fix neurips configs after hydra integration #423
Merged
@DomInvivo
Copy link
Collaborator

The new configs in #421 and #423 are modular and much more maintainable. The issue mentioned here is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Graphium paper
Development

Successfully merging a pull request may close this issue.

Configs v2 datamol-io/graphium
Fix neurips configs after hydra integration datamol-io/graphium
2 participants
@DomInvivo @s-maddrellmander