Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed test + largemix mpnn config #424

Merged
merged 13 commits into from
Aug 2, 2023
Merged

Speed test + largemix mpnn config #424

merged 13 commits into from
Aug 2, 2023

Conversation

zhiyil1230
Copy link
Contributor

@zhiyil1230 zhiyil1230 commented Aug 1, 2023

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

  • optimum parameters for the training speed of largemix and pcqm4m (mpnn): 100 epochs, 14 hours for largemix gcn and 8 hours for pcqm4mv2 mpnn
  • add mpnn largemix config (currently not in hydra, will convert to it once the largemix conversion is ready)

@zhiyil1230 zhiyil1230 requested a review from DomInvivo as a code owner August 1, 2023 10:38
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #424 (2d51bbb) into main (57399b3) will decrease coverage by 1.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   66.91%   65.25%   -1.66%     
==========================================
  Files          82       82              
  Lines        7819     7806      -13     
==========================================
- Hits         5232     5094     -138     
- Misses       2587     2712     +125     
Flag Coverage Δ
unittests 65.25% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 48.75% <ø> (-0.40%) ⬇️

@DomInvivo
Copy link
Collaborator

DomInvivo commented Aug 1, 2023

@zhiyil-graphcore , can you resolve the conflicts that were caused by merging the last 2 PR's #421 and #423 ? I'm afraid of breaking something if I do it myself.

@zhiyil1230
Copy link
Contributor Author

zhiyil1230 commented Aug 2, 2023

@zhiyil-graphcore , can you resolve the conflicts that were caused by merging the last 2 PR's #421 and #423 ? I'm afraid of breaking something if I do it myself.

I've made the changes accordingly with the latest change on hydra configs.

@DomInvivo DomInvivo merged commit 6006da5 into main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants