Create S3 production/cloud processing pipeline and update dagster infrastructure #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
commented
Sep 11, 2024
e-belfer
changed the title
bendnorman
requested changes
Sep 13, 2024
bendnorman
approved these changes
Sep 17, 2024
src/usage_metrics/etl/__init__.py
Outdated
Comment on lines
92
to
102
| resources_by_env = { # STILL TO DO! | ||
| "prod": {"database_manager": postgres_manager}, | ||
| "local": {"database_manager": sqlite_manager}, | ||
| } | ||
|
|
||
| resources = resources_by_env[os.getenv("METRICS_PROD_ENV", "local")] | ||
|
|
||
| defs: Definitions = Definitions( | ||
| assets=default_assets, | ||
| # asset_checks=default_asset_checks, | ||
| resources={"database_manager": sqlite_manager}, # TODO: How to handle this? | ||
| resources=resources, # TODO: How to handle this? |
There was a problem hiding this comment.
Can these comments be removed?
src/usage_metrics/raw/s3.py
Outdated
| @@ -73,4 +75,6 @@ def raw_s3_logs(context: AssetExecutionContext) -> pd.DataFrame: | |||
| weekly_dfs.append(pd.read_csv(path, delimiter=" ", header=None)) | |||
| except pd.errors.EmptyDataError: | |||
| context.log.warnings(f"{path} is an empty file, couldn't read.") | |||
| return pd.concat(weekly_dfs) | |||
| if weekly_dfs: # If data | |||
There was a problem hiding this comment.
Can you remove this comment or make it more descriptive, please?
src/usage_metrics/etl/__init__.py
Outdated
| @@ -12,7 +13,9 @@ | |||
| AssetsDefinition, | |||
| AssetSelection, | |||
| Definitions, | |||
| ExperimentalWarning, | |||
There was a problem hiding this comment.
It doesn't look like this is being used anywhere in the module.
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #147.
What problem does this address?
What did you change in this PR?
io_managerdecorator, and createSQLIOManagerclass to hold methods common to both SQL database typespartition_keytoload_inputandhandle_outputfunctions for both IO managersparse_dateshandling to prevent dtypes from changing when reading in and out of SQL databasesREADMEall_metrics_etlweekly and send update topudl-deploymentsTesting
How did you make sure this worked? How can a reviewer verify this?
Run
all_etllocally.To-do list
Tasks