Persist and expose BIP353 addresses #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
requested review from
dangeross,
erdemyerebasmaz,
roeierez and
hydra-yse
danielgranhao
force-pushed
the
daniel-persist-bip353-address
branch
from
a78c267 to
52e23f5
Compare
danielgranhao
force-pushed
the
daniel-persist-bip353-address
branch
from
52e23f5 to
f8a2807
Compare
This was referenced Feb 5, 2025
roeierez
reviewed
Feb 6, 2025
| @@ -67,12 +67,19 @@ interface InputType { | |||
| Bolt12Offer(LNOffer offer); | |||
| NodeId(string node_id); | |||
| Url(string url); | |||
| Bip353Address(ResolvedBip353 resolved_bip353); | |||
There was a problem hiding this comment.
Do we want to expose the Bip353Address to the user? It looks like the user will need to add extra logic to handle this (matching the internal structure). Just curious if there is an advantage vs resolving the internal structure automatically.
There was a problem hiding this comment.
@roeierez After the integration, I didn't see much benefit to having the wrapper Bip353Address as an InputType. In fact, it made things a bit more complicated. It's better to add an optional bip353_address field to Bolt12Offer & LnUrlPay as such:
Bolt12Offer(LNOffer offer, string? bip353_address);
LnUrlPay(LnUrlPayRequestData request_data, string? bip353_address);
There was a problem hiding this comment.
I applied @erdemyerebasmaz's suggestion. I didn't pursue it initially because it felt weird, but indeed it's simpler.
danielgranhao
force-pushed
the
daniel-persist-bip353-address
branch
4 times, most recently
from
f02fe47 to
1dc140a
Compare
danielgranhao
force-pushed
the
daniel-persist-bip353-address
branch
from
1dc140a to
deb1e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #714.
Depends on sdk-common PR: breez/breez-sdk-greenlight#1164
This PR adds the bip353 address to
PaymentTxDetails, persisting it locally and syncing it to other devices. The address is then exposed as an additional field ofPaymentDetails::Lightning. Technically, bip353 can also be used to fetch onchain addresses, but that isn't currently supported. We can add it toPaymentDetails::Bitcoinonce it is.Test notes
Paying to a BIP353 address that resolves to a BOLT12 or an LNURL Pay results in a payment entry that shows the bip353 that was used. Note that this will only be testable once Misty exposes the new field.