Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display BIP 353 Address information on Payment Details #356

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Display BIP 353 Address information on Payment Details #356

merged 2 commits into from
Feb 11, 2025
+37 −0

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Feb 5, 2025 •
edited
Loading

@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Feb 5, 2025 •
edited by Nackoo2000
Loading

Testing Notes

  • Scan or paste a BIP-353 Address
  • Make a payment to a BIP-353 Address
  • Check payment details for BIP-353 Address information on that payment

Ideally, use two different BIP-353 Addresses that resolves to a Bolt 12 Offer and a LnUrl Payment.
BIP-353 Address information is not shown on the payment pages, but please do give feedback to add them if it's confusing UX-wise.

These tests also cover #355

Builds:

  • Android: Under Artifacts on Build Android
  • iOS: Version 0.1.0 (6289.1) on TestFlight

CC: @Nackoo2000

@erdemyerebasmaz erdemyerebasmaz force-pushed the bip353_address_payment_details branch 2 times, most recently from 9106255 to e2a5320 Compare February 7, 2025 11:41
@erdemyerebasmaz erdemyerebasmaz marked this pull request as ready for review February 7, 2025 12:30
@erdemyerebasmaz erdemyerebasmaz force-pushed the bip353_address_payment_details branch from e2a5320 to 7c642ed Compare February 7, 2025 12:41
@erdemyerebasmaz erdemyerebasmaz changed the base branch from main to bip353_payment_data February 7, 2025 16:52
dangeross
dangeross approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a nit

...yments_list/widgets/payment_details_sheet/widgets/payment_details_sheet_bip_353_address.dart Outdated Show resolved Hide resolved
danielgranhao
danielgranhao approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@danielgranhao danielgranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erdemyerebasmaz erdemyerebasmaz merged commit 09e7052 into bip353_payment_data Feb 11, 2025
@erdemyerebasmaz erdemyerebasmaz deleted the bip353_address_payment_details branch February 11, 2025 14:56
erdemyerebasmaz added a commit that referenced this pull request Feb 11, 2025
@erdemyerebasmaz
Add input handing for Bolt 12 Offers & LNURL payments resolved from B…
b239fad 
…IP 353 Address (#355)

* Handle BIP 353 Address payments

* Display BIP 353 Address information on Payment Details (#356)

* Display BIP 353 Address information on Payment Details

* Use "Lightning Address:" as title for BIP 353 Addresses on payment details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangeross dangeross dangeross approved these changes

@danielgranhao danielgranhao danielgranhao approved these changes

Assignees

@erdemyerebasmaz erdemyerebasmaz

Labels
Testing Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display BIP 353 Address information on Payment Details
4 participants
@erdemyerebasmaz @dangeross @danielgranhao @Nackoo2000