sdk-common: Expose if BIP353 is used for parsing #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
reviewed
Feb 4, 2025
|
Looks good to me, I just prefer to review this once again together with the PR for breez/breez-sdk-liquid#714. |
dangeross
reviewed
Feb 4, 2025
Done. Updated CC: @danielgranhao |
danielgranhao
force-pushed
the
daniel-expose-bip353-usage
branch
3 times, most recently
from
e53f76a to
aac8d2f
Compare
danielgranhao
force-pushed
the
daniel-expose-bip353-usage
branch
from
3222a5a to
ec87da4
Compare
|
danielgranhao
force-pushed
the
daniel-expose-bip353-usage
branch
from
ec87da4 to
f6951d1
Compare
|
Adjusted the PR according to the feedback from breez/breez-sdk-liquid#718 (comment) |
danielgranhao
force-pushed
the
daniel-expose-bip353-usage
branch
from
f6951d1 to
43a2000
Compare
erdemyerebasmaz
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bip353_address field to Bolt12 and LnUrlPay input types to allow users of
parse()to tell if a particular input was a BIP353 address.This is needed in the nodeless SDK for breez/breez-sdk-liquid#714.