[INFRA] Ignore www.incf.org link check.. unlikely to go away (hopefully) #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently check fails
URL `https://www.incf.org/'
Name `INCF'
Parent URL file:///home/circleci/project/site/introduction.html, line 1795, col 2
Real URL https://www.incf.org/
Check time 0.084 seconds
Result Error: SSLError: HTTPSConnectionPool(host='www.incf.org', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certifica...
possibly due to outdated collection of root certificates in the env where testing?
dunno, but we better address it since it brings overall CI to red quite
often, causing fatigue and increasing likeliness to skip important issues.
Would be easier to find one, and to add one without thinking much where etc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 17 17
Lines 1499 1499
=======================================
Hits 1236 1236
Misses 263 263 ☔ View full report in Codecov by Sentry. |
yarikoptic
added
the
exclude-from-changelog
yarikoptic
added a commit
that referenced
this pull request
Jan 21, 2025
Since this way it keeps it "grey" on PRs, which causes all other matrix runs and workflows to be expanded and thus requiring more mental cycles to understand that it is actually all good. This way it should be collapsed. This commit sits on top of #2030 to ensure no other workflows fail ATM
DimitriPapadopoulos
approved these changes
Jan 21, 2025
effigies
approved these changes
Jan 21, 2025
effigies
pushed a commit
to yarikoptic/bids-specification
that referenced
this pull request
Jan 21, 2025
Since this way it keeps it "grey" on PRs, which causes all other matrix runs and workflows to be expanded and thus requiring more mental cycles to understand that it is actually all good. This way it should be collapsed. This commit sits on top of bids-standard#2030 to ensure no other workflows fail ATM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently check fails
possibly due to outdated collection of root certificates in the env where testing?
dunno, but we better address it since it brings overall CI to red quite often, causing fatigue and increasing likeliness to skip important issues.
edit: also sorted lines there for consistency etc