Skip to content

Commit

Permalink
Do check for being a pull request not at job level
Browse files Browse the repository at this point in the history
Since this way it keeps it "grey" on PRs, which causes all other
matrix runs and workflows to be expanded and thus requiring more
mental cycles to understand that it is actually all good.

This way it should be collapsed.  This commit sits on top of
bids-standard#2030
to ensure no other workflows fail ATM
  • Loading branch information
yarikoptic authored and effigies committed Jan 21, 2025
1 parent 4218b87 commit 6069e7d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/schemacode_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ jobs:
runs-on: ${{ matrix.os }}
name: Publish Python Package
needs: [test]
if: github.event_name == 'push'
strategy:
matrix:
os: ["ubuntu-latest"]
Expand All @@ -120,13 +119,14 @@ jobs:
path: dist/
- name: "Test PyPI upload"
uses: pypa/gh-action-pypi-publish@release/v1
if: github.event_name == 'push'
with:
user: __token__
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
repository-url: https://test.pypi.org/legacy/
skip-existing: true
- name: "Upload to PyPI (on tags)"
if: startsWith(github.ref, 'refs/tags/schema-')
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/schema-')
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
Expand Down

0 comments on commit 6069e7d

Please sign in to comment.