-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Do check for being a pull request not at job level #2032
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2032 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 17 17
Lines 1499 1499
=======================================
Hits 1236 1236
Misses 263 263 ☔ View full report in Codecov by Sentry. |
with my luck I do get a link fail ATM and it seems legit site down
filed |
https://www.encodeproject.org/profiles/biosample_type appears to be back online. |
Since this way it keeps it "grey" on PRs, which causes all other matrix runs and workflows to be expanded and thus requiring more mental cycles to understand that it is actually all good. This way it should be collapsed. This commit sits on top of bids-standard#2030 to ensure no other workflows fail ATM
Those were detected with codespell 2.4.0 and indeed we had inconsistencies on GB vs US forms for "localization" so it is harmonized now.
d08ce4b
to
7a43e3c
Compare
I've approved this on the grounds that it's not a big deal and it doesn't cause problems, but I also have not experienced the confusion that this addresses. I would appreciate it if a second approval comes with a concurrence that this actually solves a problem. |
FWIW, I extended original description with an example/comparison . |
Since this way it keeps it "grey" on PRs, which causes all other
matrix runs and workflows to be expanded and thus requiring more
mental cycles to understand that it is actually all good.
This way it should be collapsed. This commit sits on top of
to ensure no other workflows fail ATMSince this way it keeps it "grey" on PRs, which causes all other
matrix runs and workflows to be expanded and thus requiring more
mental cycles to understand that it is actually all good.
Relevant changes are only to the workflow file
With this we are getting
instead of
of #2035 ATM