Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Do check for being a pull request not at job level #2032

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented Jan 21, 2025

Since this way it keeps it "grey" on PRs, which causes all other
matrix runs and workflows to be expanded and thus requiring more
mental cycles to understand that it is actually all good.

This way it should be collapsed. This commit sits on top of

to ensure no other workflows fail ATMSince this way it keeps it "grey" on PRs, which causes all other
matrix runs and workflows to be expanded and thus requiring more
mental cycles to understand that it is actually all good.

Relevant changes are only to the workflow file

With this we are getting

image

instead of

image

of #2035 ATM

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (229d9f8) to head (8bddee1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2032   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files          17       17           
  Lines        1499     1499           
=======================================
  Hits         1236     1236           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added the exclude-from-changelog This item will not feature in the automatically generated changelog label Jan 21, 2025
@yarikoptic
Copy link
Collaborator Author

with my luck I do get a link fail ATM and it seems legit site down


URL        `https://www.encodeproject.org/profiles/biosample_type'
Name       `ENCODE Biosample Type'
Parent URL file:///home/circleci/project/site/modality-agnostic-files.html, line 2210, col 31
Real URL   https://www.encodeproject.org/profiles/biosample_type
Check time 60.250 seconds
Result     Error: ReadTimeout: HTTPSConnectionPool(host='www.encodeproject.org', port=443): Read timed out. (read timeout=60)

filed

@DimitriPapadopoulos
Copy link
Collaborator

https://www.encodeproject.org/profiles/biosample_type appears to be back online.

Since this way it keeps it "grey" on PRs, which causes all other
matrix runs and workflows to be expanded and thus requiring more
mental cycles to understand that it is actually all good.

This way it should be collapsed.  This commit sits on top of
bids-standard#2030
to ensure no other workflows fail ATM
Those were detected with codespell 2.4.0 and indeed we had inconsistencies on
GB vs US forms for "localization" so it is harmonized now.
@effigies
Copy link
Collaborator

I've approved this on the grounds that it's not a big deal and it doesn't cause problems, but I also have not experienced the confusion that this addresses.

I would appreciate it if a second approval comes with a concurrence that this actually solves a problem.

@yarikoptic
Copy link
Collaborator Author

FWIW, I extended original description with an example/comparison .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants