Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: k1 validator 0 address check #199

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

livingrockrises
Copy link
Contributor

@livingrockrises livingrockrises commented Oct 7, 2024

Copy link

github-actions bot commented Oct 7, 2024

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)
🟡 - unused-return (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ERC7739Validator.sol#L279-L309

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

fix: k1 validator 0 address check

Generated at commit: 452bf0c07a1f96ad687a2f2fc4a55cf326fb31aa

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
26
34

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (d312888) to head (452bf0c).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
- Coverage   85.69%   85.68%   -0.02%     
==========================================
  Files          14       14              
  Lines         923      943      +20     
  Branches      251      256       +5     
==========================================
+ Hits          791      808      +17     
- Misses        117      120       +3     
  Partials       15       15              
Files with missing lines Coverage Δ
contracts/modules/validators/K1Validator.sol 71.08% <100.00%> (+0.35%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa19840...452bf0c. Read the comment docs.

@livingrockrises livingrockrises merged commit 79376bc into dev Oct 7, 2024
10 checks passed
@livingrockrises livingrockrises deleted the fix/check-zero-address branch October 7, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants