refactor: respond to PR comment by 0xbok

[livingrockrises]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (a9eee7b) to head (d312888).
Report is 3 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #198      +/-   ##
==========================================
- Coverage   85.85%   85.69%   -0.16%     
==========================================
  Files          14       14              
  Lines         933      923      -10     
  Branches      275      251      -24     
==========================================
- Hits          801      791      -10     
  Misses        117      117              
  Partials       15       15              

Files with missing lines	Coverage Δ
contracts/modules/validators/K1Validator.sol	70.73% <100.00%> (-3.19%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9eee7b...d312888. Read the comment docs.

[openzeppelin-code]

refactor: respond to PR comment by 0xbok

Generated at commit: d312888d36c38e88820152d162af5a26d233425e

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 6 26 34

---

For more details view the full report in OpenZeppelin Code Inspector

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)
🟡 - unused-return (1 results) (Medium)

• constable-states (2 results) (Optimization)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

• ID-0
  Contract locking ether found:
  Contract NexusBootstrap has payable functions:
  • ModuleManager.receive()
  • ModuleManager.fallback(bytes)
    But does not have a function to withdraw the ether

utils/NexusBootstrap.sol#L33-L165

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

• ID-1
  ERC7739Validator._hashTypedDataForAccount(address,bytes32) ignores return value by (name,version,chainId,verifyingContract) = EIP712(account).eip712Domain()

base/ERC7739Validator.sol#L279-L309

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-2
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L10

• ID-3
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

[0xbok]

can't the owner be zero here: https://github.com/bcnmy/nexus/pull/198/files#diff-0de611a725083823f818063145fae9df78b92f67f62ed9528d5337dd17aa7e10R74-R76 ?

[livingrockrises]

oh, I thought we had zero address check in place. I think we can enforce this in onInstall and create informational issue. @0xbok

[livingrockrises]

#199