Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: k1 validator 0 address check #199

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: k1 validator 0 address check #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/modules/validators/K1Validator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ contract K1Validator is IValidator, ERC7739Validator {
/// @notice Error to indicate that the new owner cannot be a contract address
error NewOwnerIsContract();

/// @notice Error to indicate that the owner cannot be the zero address
error OwnerCannotBeZeroAddress();

/// @notice Error to indicate that the data length is invalid
error InvalidDataLength();

Expand All @@ -72,6 +75,7 @@ contract K1Validator is IValidator, ERC7739Validator {
require(data.length != 0, NoOwnerProvided());
require(!_isInitialized(msg.sender), ModuleAlreadyInitialized());
address newOwner = address(bytes20(data[:20]));
require(newOwner != address(0), OwnerCannotBeZeroAddress());
require(!_isContract(newOwner), NewOwnerIsContract());
smartAccountOwners[msg.sender] = newOwner;
if (data.length > 20) {
Expand Down
Loading