Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further streamlining changes #198

Conversation

peterwilsoncc
Copy link

This is for merging into the branch 187-streamlining.

preg_match_all returns the string being replaced, it can be used with a simple str_replace in the second instance.
makes use of update_postmeta_cache

resolves ResponsiveImagesCGgh-197
@peterwilsoncc
Copy link
Author

Added cbf7dcb
Wraps a filter around the regular expression pattern for gh-190, I named it tevkori_search_images_pattern but I am certain there is something better.

@joemcgill
Copy link
Member

Interestingly, it looks like update_postmeta_cache() doens't give us the same benefit that we were getting before, which makes me think that we're benefiting from the whole post object being cached.

There seems to be some performance boost by removing the second preg_match call in f2dc120, but it seems very slight in the examples I've tested.

@peterwilsoncc
Copy link
Author

I'll check out the other cache priming functions, maybe _prime_post_caches( $ids, false, true );

cache warming requires post data in addition to meta data.
@joemcgill
Copy link
Member

Related: #187

@joemcgill
Copy link
Member

Thanks @peterwilsoncc. I've merged most of these changes in #200. Let's do cbf7dcb in a separate pull request. I want to make sure we've let the placement of this filter simmer for a bit so we don't end up introducing back-compat issues.

@joemcgill joemcgill closed this Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants