Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further streamlining changes #198

Closed
wants to merge 4 commits into from
Closed

Further streamlining changes #198

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2dc120
Remove second regular expression in content filter
peterwilsoncc Oct 2, 2015
69ad5dd
Use correct cache warming function
peterwilsoncc Oct 2, 2015
cbf7dcb
Filter for image matching regular expression
peterwilsoncc Oct 2, 2015
ee463b3
Prime post cache for attachements
peterwilsoncc Oct 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions wp-tevko-responsive-images.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ function tevkori_filter_content_images( $content ) {

// Pattern for matching all images with a `src` from the uploads directory.
$pattern = '|<img ([^>]+' . preg_quote( $path_to_upload_dir ) . '[^>]+)>|i';
$pattern = apply_filters( 'tevkori_search_images_pattern ', $pattern );
preg_match_all( $pattern, $content, $matches );

$images = $matches[0];
Expand All @@ -321,25 +322,21 @@ function tevkori_filter_content_images( $content ) {
/**
* Warm object caches for use with wp_get_attachment_metadata.
*
* To avoid making a database call for each image, WP_Query is called
* as a single query with the IDs of all images in the post. This warms
* the object cache with the meta information for all images.
*
* This loop is not used directly.
* To avoid making a database call for each image, a single query
* warms the object cache with the meta information for all images.
**/
$attachments = new WP_Query(array(
'post_type' => 'attachment',
'posts_per_page' => '-1',
'post_status' => 'inherit',
'post__in' => $ids,
));
_prime_post_caches( $ids, false, true );
}

$content = preg_replace_callback(
$pattern,
'_tevkori_filter_content_images_callback',
$content
);
foreach( $matches[0] as $k => $image ) {
$match = array( $image, $matches[1][$k] );
$needle = $image;
$replacement = _tevkori_filter_content_images_callback( $match );
if ( false === $replacement ) {
continue;
}
$content = str_replace( $image, $replacement, $content );
}

return $content;
}
Expand Down