-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic page enhancements #96
Conversation
3d183b6
to
5e129ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - looks good, just have a small question.
@AdamHawtin can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the functionality works as expected.
I have some questions about the behaviour with highlighting/featuring draft pages. The way it's handled makes sense technically, with editors able to select to feature/highlight draft pages, but those draft pages then not appearing on the published topic page until they are published, but this isn't communicated in the editor. I wonder if it will be understood by users? Perhaps draft pages need to be highlighted in the editor with a warning that they will not show until they are published.
@AdamHawtin Echoing what Adam said. This is the same behaviour on the Generic Index page. |
@AdamHawtin @sanjeevz3009 I hear you both. We have a backlog item that looks specifically at previews in a holistic manner (CMS-356) and one that looks at release preview in particular (CMS-350) |
LGTM, two quick questions:
|
Old habits die hard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! Works as expected! One minor comment =)
03cb09e
to
708da0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is the context of this PR?
This PR adds:
onsDocumentList
componentScreencast: https://www.loom.com/share/bff403cd0e8e46a3a769a1530349ffef
To-Do:
How to review
npm run build
Follow-up Actions