Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methodology page UI tests #102

Merged
merged 34 commits into from
Feb 24, 2025
Merged

Conversation

kacperpONS
Copy link
Contributor

@kacperpONS kacperpONS commented Feb 12, 2025

What is the context of this PR?

This PR adds functional tests for the methodology page.

How to review

Run the below command to run only the test for the methodology page

poetry run behave functional_tests/ -i methodology_page.feature

or

make functional-tests

to run the whole suite to make sure that there's no conflicts/ unintended side effects.

Follow-up Actions

List any follow-up actions (if applicable), like needed documentation updates or additional testing.

@kacperpONS kacperpONS changed the title Add fix from PR #101 Methodology page UI tests Feb 12, 2025
@kacperpONS kacperpONS marked this pull request as ready for review February 14, 2025 13:36
@kacperpONS kacperpONS requested a review from a team as a code owner February 14, 2025 13:36
Copy link
Contributor

@nehakerung nehakerung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the tests are working and look good 👍

@zerolab zerolab requested a review from AdamHawtin February 20, 2025 09:32
Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

No comments within the scope of this work. @kacperpONS and I had discussions on making some things done in this PR reusable and generic as part of the POM ticket we have.

@kacperpONS kacperpONS requested a review from zerolab February 24, 2025 09:24
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

@kacperpONS kacperpONS merged commit 0302a9d into main Feb 24, 2025
9 checks passed
@kacperpONS kacperpONS deleted the methodology-page-ui-tests-CMS-323 branch February 24, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants