Tweak choose view mixins names for clarity

ONSdigital · Feb 13, 2025 · 708da0f · 708da0f
1 parent fd7c23b
commit 708da0f
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/cms/topics/viewsets.py b/cms/topics/viewsets.py
@@ -15,7 +15,7 @@
     from wagtail.query import PageQuerySet
 
 
-class FeaturedSeriesPageMixin:
+class FeaturedSeriesPageChooseViewMixin:
     model_class: ArticleSeriesPage
 
     def get_object_list(self) -> "PageQuerySet[ArticleSeriesPage]":
@@ -36,10 +36,10 @@ def columns(self) -> list["Column"]:
         ]
 
 
-class FeaturedSeriesPageChooseView(FeaturedSeriesPageMixin, ChooseView): ...
+class FeaturedSeriesPageChooseView(FeaturedSeriesPageChooseViewMixin, ChooseView): ...
 
 
-class FeaturedSeriesPageChooseResultsView(FeaturedSeriesPageMixin, ChooseResultsView): ...
+class FeaturedSeriesPageChooseResultsView(FeaturedSeriesPageChooseViewMixin, ChooseResultsView): ...
 
 
 class FeaturedSeriesPageChooserViewSet(ChooserViewSet):
@@ -52,8 +52,8 @@ class FeaturedSeriesPageChooserViewSet(ChooserViewSet):
     edit_item_text = _("Edit Article Series page")
 
 
-class HighlightedChildPageMixin:
-    def get_object_list(self) -> "PageQuerySet[StatisticalArticlePage | MethodologyPage]":
+class HighlightedChildPageChooseViewMixin:
+    def get_object_list(self) -> "PageQuerySet[Page]":
         model_class: StatisticalArticlePage | MethodologyPage = self.model_class  # type: ignore[attr-defined]
         pages: PageQuerySet[Page] = model_class.objects.all().defer_streamfields()
         if topic_page_id := self.request.GET.get("topic_page_id"):  # type: ignore[attr-defined]
@@ -90,10 +90,10 @@ def columns(self) -> list["Column"]:
         ]
 
 
-class HighlightedPagePageChooseView(HighlightedChildPageMixin, ChooseView): ...
+class HighlightedPagePageChooseView(HighlightedChildPageChooseViewMixin, ChooseView): ...
 
 
-class HighlightedPagePageChooseResultsView(HighlightedChildPageMixin, ChooseResultsView): ...
+class HighlightedPagePageChooseResultsView(HighlightedChildPageChooseViewMixin, ChooseResultsView): ...
 
 
 class BaseHighlightedChildrenViewSet(ChooserViewSet):