-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SIM Cameras #357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ware into topic/sim-cam
…ware into topic/sim-cam
… seem built for receiving.
ClayJay3
added
enhancement
Requests for new features or improvements to existing features.
5-Star
Indicates a very difficult task, suitable for experts or those with extensive experience, requiring
labels
Jan 4, 2025
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 20:43 — with
GitHub Actions
Inactive
…ware into topic/sim-cam
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:25 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
ClayJay3
temporarily deployed
to
docker-packages
January 5, 2025 23:43 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5-Star
Indicates a very difficult task, suitable for experts or those with extensive experience, requiring
cameras
Tasks or issues specifically related to camera components, feeds, or image processing.
cleanup
Code refactoring or cleanup tasks to remove deprecated features, improve clarity, or ensure code qua
dev-environment
Issues or enhancements related to setting up or maintaining the development environment.
docker
Tasks or issues related to Docker containerization, including Dockerfile configuration and environme
enhancement
Requests for new features or improvements to existing features.
simulator
Tasks related to the simulator environment, including setup, enhancements, and testing.
state-machine
Issues related to the implementation, design, or modification of state machines in the system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces significant updates and enhancements to the simulation camera system, specifically for Unreal Engine Pixel Streaming integration. These changes improve the functionality, stability, and extensibility of the SIMZEDCam module and related components. SIMBasicCam has also been written, but is not currently used because no BasicCams are used in the simulator.
Changes Made
Implemented RGB frame streaming functionality from the simulation camera.
Refactored WebRTC-related logic into a reusable object.
Fixed WebRTC stream selection bugs.
Added support for multiple simulation camera feeds.
Enhanced depth measurement capabilities and stability improvements.
Improved inheritance structure for camera modules with polymorphism. This allows the entire codebase to switch between SIM and normal USB cameras without the user having to do any extra logic in their own code. It just works.
Refactored the ZEDCam decoding logic for better performance and maintainability.
Updated SIMZEDCam to retrieve the navboard position accurately. This is used to emulate the VIO tracking.
Enabled DataChannel communication for Pixel Streaming commands.
Added point cloud calculation capability to SIMZEDCam.
Added logic to switch RoveComm_CPP over to sending to an IP specified in AutonomyConstants instead of just sending to localhost.
Other Changes
How It Works
Testing
Screenshots/Video (if applicable)
Performance Improvements
Known Issues
Additional Context