uberftp 2.8 #40848
uberftp 2.8 #40848
Conversation
| flavor = case core | ||
| when /gcc64dbg/ then "gcc64dbg" | ||
| when /gcc32dbg/ then "gcc32dbg" | ||
| if globus_version.to_s[0].to_i >= 6 |
There was a problem hiding this comment.
We always know what that version would be so we shouldn't need to make an if here?
There was a problem hiding this comment.
If somebody pinned the globus version to an older version, he can't compile uberftp anymore. However, if that is not a use case I can drop the if condition here.
There was a problem hiding this comment.
Yeh, I'd drop the conditional here, thanks.
|
Any movement upstream? |
|
There is already a pull request upstream JasonAlt/UberFTP#8, which will solve parts of the problem. No reaction since 18th, June. |
|
Does using the proposed patch removes the need for these patch do
url "https://patch-diff.githubusercontent.com/raw/JasonAlt/UberFTP/pull/8.patch"
sha256 "..."
end |
| sha256 "29a111a86fa70dbbc529a5d3e5a6befc1681e64e32dc019a1a6a98cd43ffb204" | ||
| homepage 'http://dims.ncsa.illinois.edu/set/uberftp/' | ||
| url 'https://github.com/JasonAlt/UberFTP/archive/Version_2_8.tar.gz' | ||
| sha256 '8a397d6ef02bb714bb0cbdb259819fc2311f5d36231783cd520d606c97759c2a' |
There was a problem hiding this comment.
Please use double quotes here.
|
Ping? |
|
Closing due to no response. Feel free to open another PR that addresses the comments above. Thanks! |
Closes #41277 and is based on work described in #40848. The single quotes are replaced by double quotes. The patch JasonAlt/UberFTP#8 mentioned in #40848 solves the problem partly: there is still another patch needed which obfuscate the formula even more then the replaces now.
Hi,
version has bumped to 2.8. In addition, I fixed a problem that uberftp do not compile with globus-toolkit versions >= 6.0. Could you review and merge, please.
Thanks,
Manuel