Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

uberftp 2.8 #40848

Closed
wants to merge 2 commits into from
Closed

uberftp 2.8 #40848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fac31e
uberftp 2.8
giffels Jun 18, 2015
c7ee648
Added comment, why inreplace is needed.
giffels Sep 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions Library/Formula/uberftp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,19 @@
class Uberftp < Formula
desc "Interactive GridFTP client"
homepage "http://dims.ncsa.illinois.edu/set/uberftp/"
url "https://github.com/JasonAlt/UberFTP/archive/Version_2_7.tar.gz"
sha256 "29a111a86fa70dbbc529a5d3e5a6befc1681e64e32dc019a1a6a98cd43ffb204"
homepage 'http://dims.ncsa.illinois.edu/set/uberftp/'
url 'https://github.com/JasonAlt/UberFTP/archive/Version_2_8.tar.gz'
sha256 '8a397d6ef02bb714bb0cbdb259819fc2311f5d36231783cd520d606c97759c2a'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use double quotes here.


depends_on "globus-toolkit"

def install
# get the flavor
globus = Formula["globus-toolkit"].opt_prefix

core = `"#{globus}/sbin/gpt-query" globus_core`
flavor = case core
when /gcc64dbg/ then "gcc64dbg"
when /gcc32dbg/ then "gcc32dbg"
end
#patches needed since location changed with globus-toolkit versions >= 6.0, patch to upstream not yet merged https://github.com/JasonAlt/UberFTP/pull/8
inreplace "configure", "globus_location/include/globus/gcc64dbg", "globus_location/libexec/include"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this would break 32-bit builds? Can you please submit these patches to the upstream developers of this project and add a link to the upstream patch submission and explanation of why the patch is needed in a comment in the formula file. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpt-query is not available anymore in globus version 6.0 and there is no differentiation between gcc64dbg and gcc32dbg anymore. In addition, have a look at #22037 (comment), please.
I will prepare a patch and send it to the upstream developers, for the time being this patch is fixing the uberftp compilation errors. I will add a comment to the formula file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool. Let's get the patch submitting upstream before we include this, thanks!

inreplace "configure", "globus_location/lib64", "globus_location/libexec/lib"

system "./configure", "--prefix=#{prefix}",
"--with-globus-flavor=#{flavor}",
"--with-globus=#{globus}"
system "make"
system "make", "install"
Expand Down