This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
Uberftp 2.8 #48447
Closed
Uberftp 2.8 #48447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2016 16:49
Update uberftp to version 2.8 based on work done by giffels (closed pull request #40848). The patch provided at JasonAlt/UberFTP#8 make the situation worse: another patch is needed to get configure running well and cause more obfuscation than the 2 replace commands. Replaced the single quotes in formula for double qoutes
Closes #41277 and is based on work desribed in #40848. The single quotes are replaced by double quotes. The patch JasonAlt/UberFTP#8 mentioned in #40848 solves the problem partly: there is still another patch needed which obfuscate the formula even more then the replaces now.
| when /gcc64dbg/ then "gcc64dbg" | ||
| when /gcc32dbg/ then "gcc32dbg" | ||
| end | ||
| #patches needed since location changed with globus-toolkit versions >= 6.0, patch to upstream not yet merged https://github.com/JasonAlt/UberFTP/pull/8, but solves not whole problem |
There was a problem hiding this comment.
Add space after # and wrap this line at 80 characters.
|
Looks good now. Could you squash this to a single commit so we have a tidy commit history? |
|
I will try to squash the commits today or tomorrow. Please bear with me: my experience with git is limited. |
|
@maarten-k I'll squash them for you. |
|
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
|
@MikeMcQuaid Thanks for squashing and for maintaining this awesome project! |
|
Closing, since the pull request is committed in master 03a12ec |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update uberftp to version 2.8 based on work done by giffels (closed pull request #40848).