Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workflow resolvers #376

Merged
merged 12 commits into from
Jan 31, 2025
Merged

Refactor workflow resolvers #376

merged 12 commits into from
Jan 31, 2025

Conversation

yousefmoazzam
Copy link
Collaborator

A tentative attempt to do the refactoring mentioned in #288 (comment)

@yousefmoazzam yousefmoazzam added the rust Pull request that updates Rust code label Jan 23, 2025
@yousefmoazzam yousefmoazzam force-pushed the refactor-workflow-resolvers branch from 7d3da9c to 6d00ac0 Compare January 27, 2025 15:35
@yousefmoazzam yousefmoazzam changed the base branch from main to add-workflow-status-tests January 27, 2025 15:35
@yousefmoazzam yousefmoazzam mentioned this pull request Jan 27, 2025
Open
garryod
garryod requested changes Jan 27, 2025
View reviewed changes
graph-proxy/src/graphql/workflows.rs Outdated Show resolved Hide resolved
graph-proxy/src/graphql/workflows.rs Outdated Show resolved Hide resolved
Base automatically changed from add-workflow-status-tests to main January 27, 2025 16:57
@yousefmoazzam yousefmoazzam force-pushed the refactor-workflow-resolvers branch from 6d00ac0 to 0b2b7d9 Compare January 29, 2025 11:10
@yousefmoazzam yousefmoazzam marked this pull request as draft January 29, 2025 11:44
@yousefmoazzam yousefmoazzam force-pushed the refactor-workflow-resolvers branch from 33702fa to 285168e Compare January 29, 2025 12:00
@yousefmoazzam
Copy link
Collaborator Author

I don't fully understand the lifetime elision rule(s) being applied to allow omission of the named lifetime annotation on the impl blocks, but I don't think it's worth me blocking review for that. I pinky promise to do some reading so then I understand it soon... 😅

@yousefmoazzam yousefmoazzam marked this pull request as ready for review January 29, 2025 12:05
@yousefmoazzam
Store top-level workflow manifest in an Arc
9c03803 
`Workflow` now has all user-defined resolver functions. The resolver
function which needs to pass along information from the workflow
manifest clones the `Arc` wrapping the workflow manifest and passes
that.
@yousefmoazzam
Modify Task to have user-defined resolver functions
7811e0b
@yousefmoazzam
Modify WorkflowRunningStatus to have user-defined resolver functions
90e5ad2
@yousefmoazzam
Modify WorkflowPendingStatus to have user-defined resolver functions
b4ac4ac
@yousefmoazzam
Modify WorkflowCompleteStatus to have user-defined resolver functions
878e607 
This causes two failing tests relating to the failure to fetch missing
info from the argo server response.
@yousefmoazzam
Remove intermediate Tasks enum for fetching missing data
0f1e8a0
@yousefmoazzam
Move fetching missing task info to separate function
3fed56a
@yousefmoazzam
Pass status manifest reference to workflow status structs
2fca5df
@yousefmoazzam yousefmoazzam force-pushed the refactor-workflow-resolvers branch from 285168e to 4ae0ebb Compare January 29, 2025 16:11
garryod
garryod requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple tiny things that could be tidied up

graph-proxy/src/graphql/workflows.rs Outdated Show resolved Hide resolved
graph-proxy/src/graphql/workflows.rs Outdated Show resolved Hide resolved
@yousefmoazzam yousefmoazzam force-pushed the refactor-workflow-resolvers branch from 666f2ae to d484744 Compare January 30, 2025 13:29
garryod
garryod approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yousefmoazzam yousefmoazzam merged commit e4193ea into main Jan 31, 2025
30 checks passed
@yousefmoazzam yousefmoazzam deleted the refactor-workflow-resolvers branch January 31, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garryod garryod garryod approved these changes

Assignees
No one assigned
Labels
rust Pull request that updates Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yousefmoazzam @garryod