Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflow resolvers #376

Merged
merged 12 commits into from
Jan 31, 2025
Merged

Refactor workflow resolvers #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9c03803
Store top-level workflow manifest in an `Arc`
yousefmoazzam Jan 21, 2025
7811e0b
Modify `Task` to have user-defined resolver functions
yousefmoazzam Jan 21, 2025
90e5ad2
Modify `WorkflowRunningStatus` to have user-defined resolver functions
yousefmoazzam Jan 23, 2025
b4ac4ac
Modify `WorkflowPendingStatus` to have user-defined resolver functions
yousefmoazzam Jan 23, 2025
878e607
Modify `WorkflowCompleteStatus` to have user-defined resolver functions
yousefmoazzam Jan 23, 2025
0f1e8a0
Remove intermediate `Tasks` enum for fetching missing data
yousefmoazzam Jan 23, 2025
3fed56a
Move fetching missing task info to separate function
yousefmoazzam Jan 23, 2025
2fca5df
Pass status manifest reference to workflow status structs
yousefmoazzam Jan 29, 2025
53b7a03
Pass metadata reference to workflow status structs
yousefmoazzam Jan 29, 2025
83c3b3e
Simplify workflow status constructor
yousefmoazzam Jan 29, 2025
9347cab
Remove unnecessary `Arc` wrapping single-owner value
yousefmoazzam Jan 30, 2025
d484744
Use string ref instead of cloned owned string
yousefmoazzam Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graph-proxy/src/graphql/workflow_templates.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ impl WorkflowTemplatesMutation {
.json::<APIResult<argo_workflows_openapi::IoArgoprojWorkflowV1alpha1Workflow>>()
.await?
.into_result()?;
Ok(Workflow::new(workflow, visit.into())?)
Ok(Workflow::new(workflow, visit.into()))
}
}

Expand Down
Loading