Use string ref instead of cloned owned string

DiamondLightSource · Jan 30, 2025 · d484744 · d484744
1 parent 9347cab
commit d484744
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/graph-proxy/src/graphql/workflows.rs b/graph-proxy/src/graphql/workflows.rs
@@ -138,8 +138,8 @@ struct WorkflowPendingStatus<'a>(&'a IoArgoprojWorkflowV1alpha1WorkflowStatus);
 #[Object]
 impl WorkflowPendingStatus<'_> {
     /// A human readable message indicating details about why the workflow is in this condition
-    async fn message(&self) -> Option<String> {
-        self.0.message.clone()
+    async fn message(&self) -> Option<&str> {
+        self.0.message.as_deref()
     }
 }
 
@@ -163,8 +163,8 @@ impl WorkflowRunningStatus<'_> {
     }
 
     /// A human readable message indicating details about why the workflow is in this condition
-    async fn message(&self) -> Option<String> {
-        self.manifest.message.clone()
+    async fn message(&self) -> Option<&str> {
+        self.manifest.message.as_deref()
     }
 
     /// Tasks created by the workflow
@@ -231,8 +231,8 @@ impl WorkflowCompleteStatus<'_> {
     }
 
     /// A human readable message indicating details about why the workflow is in this condition
-    async fn message(&self) -> Option<String> {
-        self.manifest.message.clone()
+    async fn message(&self) -> Option<&str> {
+        self.manifest.message.as_deref()
     }
 
     /// Tasks created by the workflow