Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8975 Paragraph order #742

Merged
merged 2 commits into from
Jan 18, 2024
Merged

UHF-8975 Paragraph order #742

merged 2 commits into from
Jan 18, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jan 16, 2024 •
edited by teroelonen
Loading

UHF-8975

What was done

  • Updated the order for sote related paragraph type orders.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Checkout this branch
    • git fetch -all && git checkout UHF-8975_paragraph_order
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8975_paragraph_order
  • Run make drush-cim drush-updb drush-cr

How to test

  • Download the excel file of correct paragraphs orders from https://helsinkisolutionoffice.atlassian.net/browse/UHF-8975
  • Go to add/edit the following entities and check that the paragraphs (in Finnish) are in the same order as in the excel file
    • Landing page
    • Standard page
    • TPR Unit
    • TPR Service
  • Check that code follows our standards

Other PRs

This was referenced Jan 16, 2024
Merged
Merged
Merged
Merged
@khalima khalima marked this pull request as ready for review January 16, 2024 14:40
@khalima khalima mentioned this pull request Jan 16, 2024
Merged
5 tasks
teroelonen
teroelonen requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one untranslated paragraph: Unit contact card - Pitäisi olla Toimipisteen yhteystiedot and it should probably be the last item on Landing page as well since it is there on basic page (this is guess tho since it is not in the Landing page table in the excel)

Also Palvelulistaus was called Palvelut in the excel so that name should be updated.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khalima
Copy link
Contributor Author

khalima commented Jan 18, 2024

There is one untranslated paragraph: Unit contact card - Pitäisi olla Toimipisteen yhteystiedot and it should probably be the last item on Landing page as well since it is there on basic page (this is guess tho since it is not in the Landing page table in the excel)

Also Palvelulistaus was called Palvelut in the excel so that name should be updated.

These should be fixed in f35c745

teroelonen
teroelonen approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good now 🦖

@khalima khalima merged commit 5369df3 into dev Jan 18, 2024
2 checks passed
@khalima khalima deleted the UHF-8975_paragraph_order branch January 18, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen