Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8975 Paragraph order #370

Merged
merged 2 commits into from
Jan 18, 2024
Merged

UHF-8975 Paragraph order #370

merged 2 commits into from
Jan 18, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jan 16, 2024

UHF-8975

❗ Notice! Installing the platform config branch UHF-8975_paragraph_order locally will also install the D10.2 version. Make sure to remove the conflict section of your local composer.json file if it still exists. ❗

What was done

  • Updated the order for 'päätökset' related paragraph types.
  • Added translations for the custom content links, meetings calendar and pdf listing paragraphs.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Checkout this branch
    • git fetch -all && git checkout UHF-8975_paragraph_order
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8975_paragraph_order -W
  • Run make drush-cim drush-updb drush-cr

How to test

  • Download the excel file of paragraphs order from https://helsinkisolutionoffice.atlassian.net/browse/UHF-8975
  • Go to add/edit the following entities and check that the paragraphs (in Finnish) are in the same order as in the excel file. Note that the custom paragraph order is not a perfect match with the excel. The ones what are committed in this branch and are seen in the pictures below are correct.
    • Landing page
    • Standard page
  • Check that code follows our standards

Check the images below for the correct order:
Landing page
image
Standard page upper content
image
Standard page lower content
image

Other PRs

@khalima khalima changed the title Uhf 8975 paragraph order UHF-8975 Paragraph order Jan 16, 2024
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

@khalima khalima merged commit e6b963b into dev Jan 18, 2024
@khalima khalima deleted the UHF-8975_paragraph_order branch January 18, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants