Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8975 Paragraph order #677

Merged
merged 18 commits into from
Jan 18, 2024
Merged

UHF-8975 Paragraph order #677

merged 18 commits into from
Jan 18, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jan 16, 2024

UHF-8975

What was done

  • Updated the orders of paragraphs when adding/editing Landing page, standard page, news item, TPR unit and TPR service

How to install

  • ❗ You can test the platform config changes on Strategia, Kuva, Asuminen or Elo as they do not have customized paragraph configurations
  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8975_paragraph_order
  • Run make drush-updb drush-cr

How to test

  • Download the excel file of correct paragraphs orders from https://helsinkisolutionoffice.atlassian.net/browse/UHF-8975
  • Go to add/edit the following entities and check that the paragraphs (in Finnish) are in the same order as in the excel file
    • Landing page
    • Standard page
    • TPR Unit
    • TPR Service
  • Check that code follows our standards

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54d989a) 13.07% compared to head (e79030f) 13.07%.

❗ Current head e79030f differs from pull request most recent head 23873a6. Consider uploading reports for the commit 23873a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #677   +/-   ##
=========================================
  Coverage     13.07%   13.07%           
  Complexity      242      242           
=========================================
  Files            28       28           
  Lines           941      941           
=========================================
  Hits            123      123           
  Misses          818      818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khalima khalima marked this pull request as ready for review January 16, 2024 10:27
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work, you are the king 🦖

@khalima khalima merged commit 0008485 into main Jan 18, 2024
@khalima khalima deleted the UHF-8975_paragraph_order branch January 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants