drivers: serial: nrfx_uarte: Add requesting of HSFLL GD clock when fast UARTE (uart120) is used #82103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct :) |
hubertmis
previously approved these changes
Nov 27, 2024
nordic-krch
force-pushed
the
uart_hsfll
branch
from
42b2610 to
d634eee
Compare
zephyrbot
added
platform: nRF
zephyrbot
requested review from
anangl,
dcpleung,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
nordic-krch
force-pushed
the
uart_hsfll
branch
2 times, most recently
from
0210d32 to
6979d1a
Compare
zephyrbot
added
area: Clock Control
area: Base OS
zephyrbot
requested review from
andyross,
decsny,
galak,
nashif,
peter-mitsis and
rruuaanng
nordic-krch
force-pushed
the
uart_hsfll
branch
from
6979d1a to
83b4112
Compare
| /* Macro must resolve to literal 0 or 1 */ | ||
| #define INSTANCE_IS_FAST(unused, prefix, idx, _) \ | ||
| COND_CODE_1(DT_NODE_HAS_STATUS_OKAY(UARTE(idx)), \ |
There was a problem hiding this comment.
This should stay so that it does not take disabled instances into account
This was referenced Dec 12, 2024
nordic-krch
force-pushed
the
uart_hsfll
branch
from
83b4112 to
5e192c1
Compare
kl-cruz
previously approved these changes
Dec 13, 2024
nika-nordic
previously approved these changes
Dec 13, 2024
nordic-krch
dismissed stale reviews from nika-nordic and kl-cruz
via
e234a23
nordic-krch
force-pushed
the
uart_hsfll
branch
2 times, most recently
from
e234a23 to
60277e0
Compare
|
Merged as part of nrfconnect/sdk-zephyr#2385 |
Reopening as the commits still need to be merged upstream. In the above PR, they were only cherry-picked into the downstream fork. |
|
Rebased. |
|
ah my bad :) I did not notice this one was upstream :) |
|
is the DNM intentional? |
bjarki-andreasen
approved these changes
Jan 6, 2025
nordic-krch
force-pushed
the
uart_hsfll
branch
from
f8f9ed7 to
051140b
Compare
Add clock source for timer120 and timer121 nodes Signed-off-by: Krzysztof Chruściński <[email protected]>
Add requesting for global HFSLL when fast instance TIMER (e.g. TIMER120 in nrf54h20) is used. Signed-off-by: Krzysztof Chruściński <[email protected]>
Request fast global domain to run at 320 MHz during fast UARTE activity. As request is asynchronous it cannot be called from an ISR. Due to complexity to handle that without device runtime power management a requirement is added so that if fast UARTE is used device runtime PM must be enabled. Clock is request and released in PM resume and suspended actions which in case of fast UARTE are only called from thread context. Signed-off-by: Krzysztof Chruściński <[email protected]>
Enable device runtime PM for nrf54h20dk/nrf54h20/cpuapp where fast UARTE (uart120) is tested. Signed-off-by: Krzysztof Chruściński <[email protected]>
dcpleung
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clock request and release in resume and suspend actions. It is required for the fast UARTE peripheral (uart120 in nrf54h20). Since it would be tricky to handle that outside of PM actions added build time check which enforces use of device runtime PM when fast UARTE is used (device power PM is de facto a must in nrf54h20 so it is not a real limitation).
Due to device runtime PM requirement,
uart_async_apitest configuration for nrf54h20dk/nrf54h20/cpuapp has been extended to enable PM.Work from PR #81527 had to be included.DNM until #81735.