drivers: pwm: nrfx: add global hsfll request for fast PWM #82133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstasiaknordic
force-pushed
the
pwm_global_hsfll
branch
3 times, most recently
from
e94eb66 to
1e59406
Compare
zephyrbot
requested review from
anangl,
henrikbrixandersen,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
|
@bjarki-andreasen You can have a look |
mstasiaknordic
force-pushed
the
pwm_global_hsfll
branch
3 times, most recently
from
98008da to
89e31f4
Compare
zephyrbot
added
area: Devicetree
area: Base OS
zephyrbot
requested review from
andyross,
dcpleung,
decsny,
galak,
nashif and
nordic-krch
mstasiaknordic
dismissed stale reviews from bjarki-andreasen and nika-nordic
via
189c159
mstasiaknordic
force-pushed
the
pwm_global_hsfll
branch
from
7e65732 to
189c159
Compare
mstasiaknordic
force-pushed
the
pwm_global_hsfll
branch
from
189c159 to
6f113f8
Compare
nordic-krch
previously approved these changes
Jan 13, 2025
bjarki-andreasen
previously approved these changes
Jan 13, 2025
kartben
force-pushed
the
pwm_global_hsfll
branch
from
6f113f8 to
c4118a1
Compare
masz-nordic
reviewed
Jan 17, 2025
mstasiaknordic
dismissed stale reviews from nordic-krch and bjarki-andreasen
via
5b88b7e
mstasiaknordic
force-pushed
the
pwm_global_hsfll
branch
from
c4118a1 to
5b88b7e
Compare
mstasiaknordic
requested review from
masz-nordic,
bjarki-andreasen,
nika-nordic and
nordic-krch
masz-nordic
previously approved these changes
Jan 17, 2025
nika-nordic
previously approved these changes
Jan 17, 2025
anangl
reviewed
Jan 17, 2025
drivers/pwm/pwm_nrfx.c
Outdated
| @@ -248,6 +283,20 @@ static int pwm_nrfx_set_cycles(const struct device *dev, uint32_t channel, | |||
| * until another playback is requested (new values will be | |||
| * loaded then) or the PWM peripheral is stopped. | |||
| */ | |||
| #if PWM_NRFX_USE_CLOCK_CONTROL | |||
| if (!data->clock_requested && config->clk_dev) { | |||
There was a problem hiding this comment.
nit: with config->clk_dev && !data->clock_requested you could avoid clock_requested being checked for instances that don't need to request clock anyway
drivers/pwm/pwm_nrfx.c
Outdated
| @@ -229,6 +252,18 @@ static int pwm_nrfx_set_cycles(const struct device *dev, uint32_t channel, | |||
| * ensure it is stopped before starting the next playback. | |||
| */ | |||
| nrfx_pwm_stop(&config->pwm, false); | |||
| #if PWM_NRFX_USE_CLOCK_CONTROL | |||
| if (data->clock_requested && config->clk_dev) { | |||
There was a problem hiding this comment.
Checking of config->clk_dev is redundant here.
Same piece of code for stopping the PWM and releasing the clock is used in pwm_suspend(). How about using a helper function for this to avoid duplication?
Added clock control api for global hsfll used in fast PWM120 driver. Signed-off-by: Michał Stasiak <[email protected]>
mstasiaknordic
dismissed stale reviews from nika-nordic and masz-nordic
via
06d88a4
mstasiaknordic
force-pushed
the
pwm_global_hsfll
branch
from
5b88b7e to
06d88a4
Compare
anangl
approved these changes
Jan 17, 2025
bjarki-andreasen
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clock control api for global hsfll used in fast PWM120 driver.