Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add missing functions to contract interface #1773

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion contracts/src/core/AlignedLayerServiceManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ contract AlignedLayerServiceManager is
function checkPublicInput(
bytes calldata publicInput,
bytes32 hash
) public pure returns (bool) {
) external pure returns (bool) {
return keccak256(publicInput) == hash;
}
Copy link
Contributor

@MauroToscano MauroToscano Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, but it's mostly to reduce a bit the cost, right ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is. We don't use this function in the contract, so it can be external.


Expand Down
6 changes: 6 additions & 0 deletions contracts/src/core/IAlignedLayerServiceManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,10 @@ interface IAlignedLayerServiceManager {
function enableVerifier(uint8 verifierIdx) external;

function setDisabledVerifiers(uint256 bitmap) external;

function withdraw(uint256 amount) external;

function depositToBatcher(address account) external payable;

function checkPublicInput(bytes calldata publicInput, bytes32 hash) external pure returns (bool);
}
Loading