-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add missing functions to contract interface #1773
base: staging
Are you sure you want to change the base?
refactor: add missing functions to contract interface #1773
Conversation
) external pure returns (bool) { | ||
return keccak256(publicInput) == hash; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change, but it's mostly to reduce a bit the cost, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is. We don't use this function in the contract, so it can be external.
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Add missing functions to contract interface
Description
Some functions where not defined in the interface IAlignedServiceManager.sol
Type of change
Please delete options that are not relevant.
Checklist
testnet
, everything else tostaging