AccessibilityManager's handleKey should be triggered by onData, not onKey #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikicha
changed the title
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.packages.modules.Virtualization
that referenced
this pull request
Nov 27, 2024
With IME, onKey doesn't work well, so xtermjs cannot clean up previous content properly. So use onData instead. xtermjs/xterm.js#5221 is the upstream change. Bug: 376827479 Bug: 376824356 Test: type something + enter, and then type something + space, and then check talkback behavior. Change-Id: I6dd2edf8a7aa4d7a29587581b5bd56108bfb7af3
|
@Tyriar ping.. |
|
@ikicha Does that still work the same way? Plz note, that Sorry I cannot really review this, as I literally have no clue about accessibility's best practices. |
|
We can't use What this change also does is run
This was general advice to embedders of the lib. Closing since we can't accept this and a different fix would likely look pretty different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In Android, screen reader feature sometimes generates the voice output including previous content
Reason:
_liveRegion.textContentfrom previous command is supposed be cleaned up in key stroke event, but onKey doesn't work as intended with IME(except 'enter' in Android) as mentioned in #3025. So the voice output includes previous content.Fix:
As @Tyriars said in #3025, use
onDatainstead ofonKey