Skip to content

Commit

Permalink
Fix xtermjs a11y bug about onKey
Browse files Browse the repository at this point in the history
With IME, onKey doesn't work well, so xtermjs cannot clean up previous
content properly. So use onData instead.

xtermjs/xterm.js#5221 is the upstream change.

Bug: 376827479
Bug: 376824356
Test: type something + enter, and then type something + space, and then
check talkback behavior.

Change-Id: I6dd2edf8a7aa4d7a29587581b5bd56108bfb7af3
  • Loading branch information
ikicha committed Nov 21, 2024
1 parent fc5d465 commit d160b2f
Show file tree
Hide file tree
Showing 2 changed files with 32,021 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build/debian/ttyd/cross-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ build_libwebsockets() {

build_ttyd() {
echo "=== Building ttyd (${TARGET})..."
# TODO: Remove this when https://github.com/xtermjs/xterm.js/pull/5221 is
# deployed
patch -p1 < $(dirname $0)/xtermjs_a11y.patch
rm -rf build && mkdir -p build && cd build
cmake -DCMAKE_TOOLCHAIN_FILE="${BUILD_DIR}/cross-${TARGET}.cmake" \
-DCMAKE_INSTALL_PREFIX="${STAGE_DIR}" \
Expand Down
Loading

0 comments on commit d160b2f

Please sign in to comment.