-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SCIM custom claim dialect related test issue #21294
Fix SCIM custom claim dialect related test issue #21294
Conversation
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11242508191
@PasinduYeshan Any idea why it was giving the error as |
...so2/identity/integration/test/scim2/rest/api/customSchema/SCIM2CustomSchemaUserTestCase.java
Outdated
Show resolved
Hide resolved
After analyzing the bytecode, it looks like the error is actually coming from the error handling code itself, specifically this line: Problem is likely related to deserializing the SOAP fault response, rather than the main method call. |
PR builder started |
.../wso2/identity/integration/test/scim2/rest/api/customSchema/SCIM2CustomSchemaMeTestCase.java
Outdated
Show resolved
Hide resolved
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11252061085
Fix:
The SCIM2CustomSchemaUserTestCase.createClaims() test is failing with a NoSuchMethodError:
Root Cause
This error is occurring due to changes introduced in PR #5661 (wso2/carbon-identity-framework#5661). That PR added claims to the "urn:scim:wso2:schema" dialect by default. However, the SCIM2CustomSchemaUserTestCase assumes this custom dialect URI is not set and attempts to create the claim dialect within the test.
Solution
Updated test to, check if custom schema dialect exists and create dialect only if it doesn't exist.
is-tests-scim2 tests passed locally with this change.
![image](https://private-user-images.githubusercontent.com/61885844/374702472-e41ca1fa-f982-4c68-950f-3450048bbd99.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzEyMDQsIm5iZiI6MTczOTIzMDkwNCwicGF0aCI6Ii82MTg4NTg0NC8zNzQ3MDI0NzItZTQxY2ExZmEtZjk4Mi00YzY4LTk1MGYtMzQ1MDA0OGJiZDk5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDIzNDE0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgxMWYyNDJmMjNlZGY4ZTA3MDY4YjYxYWE2MTlmYWE2ZmRkNmM5ZmQ5MmY1ZGNiNTk1NmEzMmNmYmQ4Y2JkOTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Ld2KX_u6p17lcjAE28QK-GLG5-90EXi7bdypWjpqXWw)