Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config changes to support multiple email addresses and mobile numbers per user #6001

Conversation

PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented Oct 9, 2024

Reverts #5998, these changes were reverted due to following integration test failure.

 [ERROR] Failures: 
 [ERROR] org.wso2.identity.integration.test.scim2.rest.api.customSchema.SCIM2CustomSchemaUserTestCase.createClaims(org.wso2.identity.integration.test.scim2.rest.api.customSchema.SCIM2CustomSchemaUserTestCase)
 [ERROR] Run 1: SCIM2CustomSchemaUserTestCase.createClaims:153 » NoSuchMethod org.wso2.carbon....
 [ERROR] Run 2: SCIM2CustomSchemaUserTestCase.createClaims:153 » NoSuchMethod org.wso2.carbon....

This failure is addressed in following PR.

Local integration tests (is-tests-scim2) were executed against the changes, and the build completed successfully.
image

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11249280604

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.17%. Comparing base (278ba34) to head (2ff90f5).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6001   +/-   ##
=========================================
  Coverage     40.16%   40.17%           
  Complexity    14170    14170           
=========================================
  Files          1734     1734           
  Lines        116973   116957   -16     
  Branches      20027    20022    -5     
=========================================
  Hits          46988    46988           
+ Misses        62766    62750   -16     
  Partials       7219     7219           
Flag Coverage Δ
unit 23.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11249280604
Status: failure

@PasinduYeshan
Copy link
Contributor Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/11249280604 Status: failure

Only expected test cases were failed.

[ERROR] Failures: 
 [ERROR] org.wso2.identity.integration.test.scim2.SCIM2UserTestCase.testAddUserFailure(org.wso2.identity.integration.test.scim2.SCIM2UserTestCase)
 [INFO] Run 1: PASS
 [ERROR] Run 2: SCIM2UserTestCase.testAddUserFailure:272 expected:<1> but was:<3>
 [INFO] 
 [ERROR] org.wso2.identity.integration.test.scim2.rest.api.customSchema.SCIM2CustomSchemaUserTestCase.createClaims(org.wso2.identity.integration.test.scim2.rest.api.customSchema.SCIM2CustomSchemaUserTestCase)
 [ERROR] Run 1: SCIM2CustomSchemaUserTestCase.createClaims:153 » NoSuchMethod org.wso2.carbon....
 [ERROR] Run 2: SCIM2CustomSchemaUserTestCase.createClaims:153 » NoSuchMethod org.wso2.carbon....
 [INFO] 
 [INFO] 
 [ERROR] Tests run: 2612, Failures: 2, Errors: 0, Skipped: 7

Therefore merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants