Support MTLS Aliases for well known endpoint #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
lalaji
reviewed
Apr 29, 2024
...rbon.identity.core/src/main/java/org/wso2/carbon/identity/core/DefaultServiceURLBuilder.java
Show resolved
Hide resolved
anjuchamantha
suggested changes
Apr 29, 2024
...rbon.identity.core/src/main/java/org/wso2/carbon/identity/core/DefaultServiceURLBuilder.java
Outdated
Show resolved
Hide resolved
...wso2.carbon.identity.core/src/main/java/org/wso2/carbon/identity/core/ServiceURLBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Anju Chamantha <[email protected]>
|
PR builder started |
lalaji
approved these changes
Apr 29, 2024
9 tasks
|
PR builder completed |
jenkins-is-staging
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8876568829
Thumimku
reviewed
Apr 30, 2024
| * @return {@link ServiceURL}. | ||
| * @throws URLBuilderException If error occurred while constructing the URL. | ||
| */ | ||
| ServiceURL build(String hostname) throws URLBuilderException; |
There was a problem hiding this comment.
Can we make this method as default cause some extension may fail because of method param mismatch
There was a problem hiding this comment.
fixed with 0f13202
DMHP
approved these changes
Apr 30, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pr adds configurations
example depployment.toml configuration
Add support to build service URL with a given hostname
Related PRs