-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MTLS Aliases endpoints to the discovery endpoint #2440
Conversation
...arbon.identity.discovery/src/main/java/org/wso2/carbon/identity/discovery/DiscoveryUtil.java
Outdated
Show resolved
Hide resolved
...so2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/util/OAuth2Util.java
Outdated
Show resolved
Hide resolved
...arbon.identity.discovery/src/main/java/org/wso2/carbon/identity/discovery/DiscoveryUtil.java
Outdated
Show resolved
Hide resolved
...so2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/util/OAuth2Util.java
Outdated
Show resolved
Hide resolved
...so2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/util/OAuth2Util.java
Outdated
Show resolved
Hide resolved
private String mtlsTokenEndpoint; | ||
private String mtlsPushedAuthorizationRequestEndpoint; | ||
|
||
private static final String MUTUAL_TLS_ALIASES_ENABLED = "OAuth.MutualTLSAliases.Enabled"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a configuration to enable /disable MTLS? For SaaS deployment can't ee depend on the existing config which we use to control other SaaS specific properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no backend config to identify a SaaS deployment. Hence added this config to enable MTLS aliases in the well known response
PR builder started |
PR builder completed |
Proposed changes in this pull request
Add MTLS Aliases endpoints to the well known OIDC discovery endpoint.
When should this PR be merged
Need a framework version bump after wso2/carbon-identity-framework#5659 is merged.
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation