Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

build: Upgrade Node and packages to latest #508

Merged
merged 21 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"root": true,
"extends": [
"wikimedia/client"
"wikimedia/server"
],
"rules": {
"camelcase": [ "error", { "properties": "never" } ]
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.21.0
19.0.1
8 changes: 8 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Wikimedia isn't using Prettier normally, would you explain in a comment where you got the rules from?
semi:false is the only one turning my head a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that I extended my personal Prettier configuration to conform with MW conventions and fix possible editor nuisances while working on this project. Though it is mostly redundant as the repo uses eslint/stylelint for JS/CSS.

It's possible that I had a good reason for it — maybe formatting HTML — but I don't remember it and it would fit better on a separate PR. Gonna revert it.

"semi": false,
"endOfLine": "lf",
"trailingComma": "none",
"singleQuote": true,
"useTabs": true
}

4 changes: 3 additions & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@
* Grunt file
*/

'use strict';

module.exports = function ( grunt ) {
/*
* PostCSS processors
*/
// Without minifier
var postCssProcessorsDev = [
const postCssProcessorsDev = [
require( 'postcss-import' )( {
from: 'css/wmui-style-guide.dev.css'
} ),
Expand Down
2 changes: 1 addition & 1 deletion css/build/wmui-style-guide.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/build/wmui-style-guide.min.css.map

Large diffs are not rendered by default.

Binary file added img/components/button_groups_intro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/components/button_groups_states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 9 additions & 9 deletions img/components/button_groups_states.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/components/buttons_designing.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion img/components/buttons_designing.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 9 additions & 9 deletions img/components/buttons_normal_and_primary_states.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/components/buttons_normal_intro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/components/buttons_quiet_states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading