This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 98
build: Upgrade Node and packages to latest #508
Merged
Merged
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
269c975
chore: Bump Node to v18.7.0
danisztls 9651ede
chore: Upgrade Node pkgs to latest
danisztls b0c063b
chore: Configure ESLint for Node (wikimedia/server) usage
danisztls 6b5e67c
chore: Config Prettier (code formatter)
danisztls 8847a5a
NPM: Install sharp and glob
danisztls b798ed8
build: Replace Squoosh with Sharp
danisztls 75d206d
NPM: Remove @squoosh/cli
danisztls 8b97143
chore: Bump node to v19.0.1
danisztls f56f88c
chore: Bump Node pkgs to latest
danisztls 4689438
fix: Issues discovered via linting task
danisztls 4e93c6c
chore: Bump pks to latest
danisztls 47da6b6
chore: Minify SVGs
danisztls 45a008e
chore: Build PNGs
danisztls 97694b6
chore: Run Grunt
danisztls 2be9fdb
Merge branch 'master' into migrate-node-18
danisztls 4edd11a
Update svg-to-png.mjs
Volker-E 425f8a4
Revert "chore: Config Prettier (code formatter)"
danisztls c43d658
Merge branch 'master' into migrate-node-18
Volker-E 0f0a08b
Merge branch 'master' into migrate-node-18
Volker-E e5fc903
Update .nvmrc
Volker-E 2e47bb5
Update package-lock.json
Volker-E File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
12.21.0 | ||
19.0.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"semi": false, | ||
"endOfLine": "lf", | ||
"trailingComma": "none", | ||
"singleQuote": true, | ||
"useTabs": true | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Wikimedia isn't using Prettier normally, would you explain in a comment where you got the rules from?
semi:false is the only one turning my head a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that I extended my personal Prettier configuration to conform with MW conventions and fix possible editor nuisances while working on this project. Though it is mostly redundant as the repo uses eslint/stylelint for JS/CSS.
It's possible that I had a good reason for it — maybe formatting HTML — but I don't remember it and it would fit better on a separate PR. Gonna revert it.