Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

build: Upgrade Node and packages to latest #508

Merged
merged 21 commits into from
Oct 12, 2023
Merged

build: Upgrade Node and packages to latest #508

merged 21 commits into from
Oct 12, 2023

Conversation

danisztls
Copy link
Contributor

@danisztls danisztls commented Aug 9, 2022 •
edited
Loading

Why?

  • Latest fixes bugs and vulnerabilities
  • Easier to do sooner than later

Tasks

@danisztls danisztls marked this pull request as ready for review August 10, 2022 01:15
@danisztls danisztls mentioned this pull request Aug 25, 2022
Closed
@Volker-E
Copy link
Collaborator

Volker-E commented Nov 8, 2022

Picking this finally up again, thanks for the patience. :) Design System and Codex had strong overhead and prio for many of the past weeks.
Could you provide more information about removing the need for NVM. Any good overview resources on it?

@danisztls
Copy link
Contributor Author

Could you provide more information about removing the need for NVM. Any good overview resources on it?

Wrong choice of words from my part. What I meant is that NVM wasn't needed at the time because the project was upgraded to the latest stable version of Node. Presently NVM is relevant due to Node 19.

It's up to discussion the merits of locking versions or upgrading packages to latest as both have their advantages and caveats. In this case the upgrade was straightforward and I don't think we are losing anything by doing it.

@danisztls danisztls changed the title Upgrade Node to v18 and pkgs to latest Upgrade Node to v19 and pkgs to latest Nov 8, 2022
@danisztls
Copy link
Contributor Author

Gonna rerun the build scripts and commit their changes to validate that the upgrade to Node 19 and Sharp isn't introducing undesired side-effects.

@danisztls
Copy link
Contributor Author

All tasks ran without errors or warnings.

Volker-E
Volker-E reviewed Feb 3, 2023
View reviewed changes
.prettierrc Outdated
@@ -0,0 +1,8 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Wikimedia isn't using Prettier normally, would you explain in a comment where you got the rules from?
semi:false is the only one turning my head a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that I extended my personal Prettier configuration to conform with MW conventions and fix possible editor nuisances while working on this project. Though it is mostly redundant as the repo uses eslint/stylelint for JS/CSS.

It's possible that I had a good reason for it — maybe formatting HTML — but I don't remember it and it would fit better on a separate PR. Gonna revert it.

@Volker-E
Copy link
Collaborator

Hey @danisztls
I'm picking this up again 😅
This time around as we're coming close to Codex 1.0, which has taken all effort. And before that I'd like to update the DSG once more.

Will update this patch slightly to use an LTS version of Node.
And rebase to include the latest dependabot security upgrades.

@Volker-E Volker-E changed the title Upgrade Node to v19 and pkgs to latest build: Upgrade Node and packages to latest Oct 12, 2023
@Volker-E
Merge branch 'master' into migrate-node-18
0f0a08b
@Volker-E
Update .nvmrc
e5fc903 
Use LTS version 18.18.1
@Volker-E
Update package-lock.json
2e47bb5 
Update to latest dependency updates after rebase and Node 18.18.1
@Volker-E Volker-E merged commit 6fef664 into wikimedia:master Oct 12, 2023
2 checks passed
@danisztls danisztls deleted the migrate-node-18 branch October 12, 2023 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Volker-E Volker-E Volker-E approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danisztls @Volker-E