Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified web page #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions starter-code/css/main.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
body {
font-weight: 200;
color: #333333;
padding: 0 25px 0 25px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorthand way to write this: padding: 0 25px;

width: 1000px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather then setting your width with pixels try using % so your site remains responsive.

}
html {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not best practice to add styles to the html tag since that would get applied to things in the <head> which never need CSS. It would be better to apply these styles to the <body>.

border-left: 5px solid #eae2de;
font-family: "Lato", sans-serif;
}
h1 a {
color: #f8ce78;
cursor: auto;
text-decoration: none;
font-weight: 200;
font-size: 50px;
padding-left: 12px;
}
h2 {
margin-left: 12px;
}
h2 a {
color: #333333;
text-decoration: none;
font-weight: 200;
margin-left: -12px;
}
h4 a {
color: #f8ce78;
text-decoration: none;
float: right;
}
h3 {
color: #eae2de;
font-size: 30px;
font-weight: 200;
margin: 0px 0px -10px 0px;
}
nav a {
color: #eae2de;
padding: 0 12px 0 12px;
}
footer nav a {
color: #f8ce78;
font-size: 12px;
margin: 0 -12px 0 -12px;
text-decoration: none;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you wrote out text-decoration: none; more than once consider adding a property to all anchors at the top of this file so you can keep your code DRY.

}
article {
border-bottom: 1px solid #eae2de;
margin: 60px 0 60px 10px;
padding-bottom: 50px;
}
footer p {
color: #eae2de;
font-size: 15px;
line-height: 15px;
display: inline-block;
border: transparent;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to specify what border property this is.. border-color:

}
p::first-letter {
line-height: 60px;
float: left;
font-size: 50px;
margin: -5px 5px 0 0;
color: #eae2de;
}
header nav a:hover {
color: rgba( 0, 0, 0, .3);
}
footer p::first-letter {
font-size: 15px;
margin-top: -23px;
}