Modified web page #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BritneyJo
reviewed
Sep 20, 2017
| body { | ||
| font-weight: 200; | ||
| color: #333333; | ||
| padding: 0 25px 0 25px; |
There was a problem hiding this comment.
Shorthand way to write this: padding: 0 25px;
| font-weight: 200; | ||
| color: #333333; | ||
| padding: 0 25px 0 25px; | ||
| width: 1000px; |
There was a problem hiding this comment.
Rather then setting your width with pixels try using % so your site remains responsive.
| padding: 0 25px 0 25px; | ||
| width: 1000px; | ||
| } | ||
| html { |
There was a problem hiding this comment.
It's not best practice to add styles to the html tag since that would get applied to things in the <head> which never need CSS. It would be better to apply these styles to the <body>.
| font-size: 15px; | ||
| line-height: 15px; | ||
| display: inline-block; | ||
| border: transparent; |
There was a problem hiding this comment.
Make sure to specify what border property this is.. border-color:
| color: #f8ce78; | ||
| font-size: 12px; | ||
| margin: 0 -12px 0 -12px; | ||
| text-decoration: none; |
There was a problem hiding this comment.
Since you wrote out text-decoration: none; more than once consider adding a property to all anchors at the top of this file so you can keep your code DRY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.