Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jesse Lewis - mockup html css lab homework. #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jesse Lewis - mockup html css lab homework. #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f6ac2
added css
Lazercat Sep 14, 2017
ca35bd4
adding some minor changes i made during group this morning
Lazercat Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 126 additions & 0 deletions starter-code/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
body {
border-left:5px #ccc solid;
margin:0 0 0 5px;
font-family: Lato;
}

header {
max-width:700px;
padding-left:24px;
}

article {
max-width:700px;
padding-left:24px;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are using the same two properties and values here, you should combine the selectors:

header, article, footer {
  max-width:700px;
  padding-left:24px;
}

footer {
padding-left:24px;
max-width:700px;
border-top:1px #ccc solid;
padding-top:25px;
}
article h3{
color:#ccc;
font-weight:100;
}

img {
max-width: 100%;
max-height: 100%;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have to set the height and width for an image, otherwise it could lead to stretching and rendering the image wonky. By using just the max-width, the height will adjust appropriately.

}

h1 {
-webkit-margin-before: 0;
-webkit-margin-after: 0;
-webkit-margin-start: 0px;
font-weight:lighter;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using the value "lighter" you should specify the font-weight given by the google font. i.e. 300.

}

h1 a{
font-weight:lighter;
margin: 5px 0;
opacity: 0.7;
font-size: 50px;
color: #FFC300;
text-decoration: none;
}

h2 {
font-size:30px;
padding:5px 0;
-webkit-margin-before: 2px;
-webkit-margin-after: 2px;
-webkit-margin-start: 0px;
-webkit-margin-end: 0px;
font-weight:200;
color: gray;
}

h2 > a {
text-decoration:none;
color:#707070;
font-weight:150;
}

h3 {
font-size:30px;
font-weight: 100;
}

h4 {
text-align:right;
}
h4 > a {
text-align:right;
text-decoration:none;
color: #FFC300;
font-weight: 100;
}
nav a {
color: #ccc;
font-stretch: 20;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you were trying to add space between the letters here. Next time use letter-spacing: 1px; and adjust from there.

font-weight:100;
font-size:16px;
}

p {
font-size:16px;
margin-top:7px;
font-weight:200;
color: #A8A8A8;
text-align:justify;

}
footer > nav {
color:#A8A8A8;
}

footer > nav a {
color: #FFC300;
text-decoration: none;
font-weight:lighter;
font-size:18px;
}

footer > p {
font-size:16px;
margin-top:7px;
font-weight:200;
color: #A8A8A8;
text-align:justify;
}

article > p::first-letter {
display:block;
font-size: 75px;
float:left;
margin-right:4px;
margin-top:0;
padding:0;
color: #BEBEBE;
font-weight:100;
text-align:left;
vertical-align: top;

}