Jesse Lewis - mockup html css lab homework. #20
Conversation
There was a problem hiding this comment.
The best way to improve your CSS is keep things DRY. That means when you start writing the same properties and values (i.e.font-size: 16px) more than once, think of a way to combine selectors so you only have to write it out one time. There is a lot of repetition in your code right now. Great job for your first mock up challenge!
| max-width:700px; | ||
| padding-left:24px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Since you are using the same two properties and values here, you should combine the selectors:
header, article, footer {
max-width:700px;
padding-left:24px;
}|
|
||
| img { | ||
| max-width: 100%; | ||
| max-height: 100%; |
There was a problem hiding this comment.
You shouldn't have to set the height and width for an image, otherwise it could lead to stretching and rendering the image wonky. By using just the max-width, the height will adjust appropriately.
| -webkit-margin-before: 0; | ||
| -webkit-margin-after: 0; | ||
| -webkit-margin-start: 0px; | ||
| font-weight:lighter; |
There was a problem hiding this comment.
Rather than using the value "lighter" you should specify the font-weight given by the google font. i.e. 300.
| } | ||
| nav a { | ||
| color: #ccc; | ||
| font-stretch: 20; |
There was a problem hiding this comment.
I think you were trying to add space between the letters here. Next time use letter-spacing: 1px; and adjust from there.
submitting css challenge homework from Wk1-Day 3.